Update check tip util functions to return both at-tip status and block id #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2021 21:52
Pull Request Test Coverage Report for Build 14242
💛 - Coveralls |
utils/utils.go
Outdated
| if fetchErr != nil { | ||
| return nil, fmt.Errorf("%w: unable to fetch network status", fetchErr) | ||
| return false, | ||
| currentStorageBlock.BlockIdentifier, |
There was a problem hiding this comment.
nit: return nil here
There was a problem hiding this comment.
Was on the fence about this. We could leave it to the caller to use or ignore the identifier based on the error.
But it will be more consistent to return nil in case of errors. Will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
We added CheckNetworkTip and CheckStorageTip utility functions to DRY these checks in the Rosetta CLI. These methods return a block identifier if the network or storage block is at tip respectively.
In some contexts, the CLI needs to know the block identifier even if it is not at tip.
Solution
Updated these methods to return at-tip status in addition to the network or storage block identifier.
Open questions