incorrect test in TestJob_ComplicatedTransfer
silently failing
#451
Labels
bug
Something isn't working
TestJob_ComplicatedTransfer
silently failing
#451
Describe the bug
I've been going through the constructor code and it seems like the following action is being populated incorrectly and then silently failing to unmarshal.
https://github.com/coinbase/rosetta-sdk-go/blob/255864dbd02229a03b9d1f209ba112bd59c26211/constructor/worker/worker_test.go#L1012-L1015
To Reproduce
if you put
println(types.PrettyPrintStruct(input))
after this block you'll see that it fails to unmarshal theKeyPair
but never throws an error.https://github.com/coinbase/rosetta-sdk-go/blob/255864dbd02229a03b9d1f209ba112bd59c26211/constructor/worker/worker.go#L258-L262
Expected behavior
seeing how this is meant to be a valid test, im assuming everything inside it should unmarshal correctly. and seeing how you have tests to reject invalid json, this should probably be throwing an error too.
Additional context
the actions input after
populate_input
mutates it:and the result of its unmarshalling inside the
SaveAccountWorker
method:The text was updated successfully, but these errors were encountered: