Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking git hooks #38

Closed
fredjaya opened this issue Oct 9, 2023 · 2 comments
Closed

Checking git hooks #38

fredjaya opened this issue Oct 9, 2023 · 2 comments

Comments

@fredjaya
Copy link
Collaborator

fredjaya commented Oct 9, 2023

Pre-commit hooks
Currently, the pre-commit script will print a success message regardless if black/isort fails.

  • Add black and isort to c3dev_environment.yml
  • Add a catch for black or isort fails in the pre-commit sample

Related to #23

Pre-push hooks
Currently, all test sessions are run (see: output) and pushing to origin fails.

  • Add instructions in wiki to avoid running all tests nox to one session nox -s test-3.10 in pre-push hook
@fredjaya
Copy link
Collaborator Author

@GavinHuttley is it ok to include black and isort as part of the c3dev conda environment, or better to install via e.g. pip until #23 is implemented?

nox as well? #36

@GavinHuttley
Copy link
Collaborator

All of these tools are specified in the pyproject.toml. I am going to delete all conda environment files.

We should be instructing users how to make a "blank" conda environment, or python virtual environment, for the correct python version and do a "developer install" using flit from their cloned repository.

Closing this issue, leaving the pre-commit hook for possibly a derivative of #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants