Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Role appears able to edit Super Administrator #510

Closed
irdublu opened this issue Apr 18, 2022 · 2 comments
Closed

Admin Role appears able to edit Super Administrator #510

irdublu opened this issue Apr 18, 2022 · 2 comments
Labels
Milestone

Comments

@irdublu
Copy link

irdublu commented Apr 18, 2022

The site I'm building in v0.10.1 has three users so far. Super Administrator (me the developer), Anonymous and a new Admin for the person who is going to be the everyday administrator. It is plain vanilla so no User Areas or special/modified code anywhere.

Admin has all the User, Role and Admin Module tickboxes ticked so they can create, edit and delete other users and roles as they may wish. When I log in as Admin and try to delete Super Admin, a message appears saying "You need to be in the super admin role to update this user.". Great. If I then try to edit the Super Admin role the system lets me, no warning. I can untick the box so Super Admin can no longer Delete or Edit Roles then click Save. I find that scary. When I go back into the Super Admin Role, the unticked tickbox is re-ticked so it appears no change was made.

Am I supposed to have set up some permission or validation code to stop the Admin thinking they can edit the Super Admin?

@HeyJoel
Copy link
Member

HeyJoel commented Apr 19, 2022

That would be a bug in the role editing UI, you can't actually save permissions against the super admin role, and as you've noted the behavior is that your changes are ignored. The bug here is that the UI allows you to edit the permissions.

@HeyJoel HeyJoel added the bug label Apr 19, 2022
@HeyJoel HeyJoel added this to the 0.11 milestone Apr 19, 2022
@HeyJoel HeyJoel modified the milestones: 0.11, 0.10.3 Apr 29, 2022
@HeyJoel HeyJoel closed this as completed in ec00ddf May 8, 2022
@HeyJoel
Copy link
Member

HeyJoel commented May 8, 2022

Fixed, will be released in 0.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants