Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnstructuredDataDependency: Rename "Root" #460

Open
HeyJoel opened this issue Nov 22, 2021 · 0 comments
Open

UnstructuredDataDependency: Rename "Root" #460

HeyJoel opened this issue Nov 22, 2021 · 0 comments

Comments

@HeyJoel
Copy link
Member

HeyJoel commented Nov 22, 2021

The term "root entity" is used in both the UnstructuredDataDependency table and in the domain layer in RootEntityMicroSummary, given that these are both closely related I think we should look at the terms here. It might be that neither needs to use "root", and instead the relationship is defined but the name of the property the entity is connecting to e.g. UnstructuredDataDependency.RootEntityId could just be UnstructuredDataDependency.EntityId, where RelatedEntityId defines that relationship.

For RootEntityMicroSummary and ChildEntityMicroSummary, again I think it would be better to rename RootEntityMicroSummary to EntityMicroSummary and have ChildEntityMicroSummary layer on top the alternative behaviour / term, but it needs more investigation.

For now I have clarified in comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant