Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin architecture for testing #36

Open
raehat opened this issue Aug 8, 2024 · 1 comment
Open

Improve plugin architecture for testing #36

raehat opened this issue Aug 8, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@raehat
Copy link
Collaborator

raehat commented Aug 8, 2024

Currently, when running the Barq plugin with Core Lightning, we need to use exclusive commands like barqpay to access payment functionality. However, it would be better to integrate our functionality into the default pay command of Core Lightning. This approach will:

  • Simplify testing by reusing the existing Core Lightning infrastructure, which is crucial for ensuring that every test passes.
  • Enhance the user experience.
@raehat raehat added the enhancement New feature or request label Aug 8, 2024
@raehat raehat self-assigned this Aug 8, 2024
@vincenzopalazzo
Copy link
Collaborator

To do this you can override the rpc_common with a plugin hook https://docs.corelightning.org/docs/hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants