Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the code #10

Open
sarrahbbh opened this issue Aug 14, 2023 · 0 comments
Open

Questions about the code #10

sarrahbbh opened this issue Aug 14, 2023 · 0 comments

Comments

@sarrahbbh
Copy link

sarrahbbh commented Aug 14, 2023

Hello! First of all thank you for this implementation
I'm currently trying to apply it on Arabic, and I have a few questions please
if you could answer my curiosities, I would be super thankful!

  1. In the def get_target_sent_by_levels function, the very first edits level (level 0) is not considered hence the instruction rest_labels = label_list[1:], why is that?
    In my data, there's only one level of edits (one error per sentence), so is it wrong to take label_list[0:]?

  2. How is the labels vocab generated? should I just take the words that are included in my training data or can I use a vocabulary from another source? What would you recommend?

Sorry if my questions are too much! I just want to make sure that I'm training my model correctly
Thank you so much in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant