Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack-dev-middleware dependency #314

Closed
mikegreiling opened this issue Mar 2, 2018 · 2 comments · Fixed by #318
Closed

Upgrade webpack-dev-middleware dependency #314

mikegreiling opened this issue Mar 2, 2018 · 2 comments · Fixed by #318

Comments

@mikegreiling
Copy link

I'm submitting a bug report

Webpack version:
4.0.1

Webpack Karma version:
2.0.7

Karma version:
2.0.0

Please tell us about your environment:
OSX 10.13.3

Browser: Chrome 64, Safari 11.0.3

Current behavior:
Currently karma-webpack has webpack-dev-middleware 1.12.0 listed as a dependency. This is two major versions behind the current release (3.0.0).

Despite #301 having added webpack v4.x as a peerDependency, installing this alongside webpack 4.0.1 will still display warnings because webpack-dev-middleware does not list webpack 4.x as a valid peer. yarn check will actually throw an error because of this.

This is the primary roadblock for my project to upgrade to webpack v4. Our CI will not accept anything for which yarn check produces an error.

Expected/desired behavior:

karma-webpack should use webpack-dev-middleware v2.0.6 which has compatibility with webpack v2.2-4.0, or release a new major version that uses webpack-dev-middleware v3.0.0 and drops compatibility with webpack 2 and 3.

  • What is the motivation / use case for changing the behavior?

wanting to use webpack 4 without warnings in my console when installing packages

@insin insin mentioned this issue Mar 7, 2018
7 tasks
@ryanclark ryanclark mentioned this issue Mar 10, 2018
9 tasks
@limonte
Copy link
Contributor

limonte commented Mar 15, 2018

For sweetalert2 the outdated dependency on webpack-dev-middleware possibly causes the "Some of your tests did a full page reload!" issue: sweetalert2/sweetalert2#986

@philipahlberg
Copy link

#316 might be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants