Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Path of karma-webpack #179

Closed
MikaAK opened this issue Oct 14, 2016 · 8 comments
Closed

Future Path of karma-webpack #179

MikaAK opened this issue Oct 14, 2016 · 8 comments

Comments

@MikaAK
Copy link
Contributor

MikaAK commented Oct 14, 2016

Decisions

A couple weeks ago we decided that there were two options for future development with karma-webpack

  1. Continue to maintain the old codebase and refactor as we go
  2. Restart from scratch with a better set of code rules and more thorough testing

It was decided option 2 would be the easiest path so we're going to gut the repo and start over. Version 1.x will still be on npm and in the v1 branch of this repo.

What this means

This means development and fixes will most likely halt unless extremely urgent while we rewrite karma-webpack. Hopefully while rewriting we can take into account a few issues such as #165, #130, #149 and performance.

CC: @d3viant0ne @DanielaValero @goldhand @jon301 @carlos-

@UnsungHero97
Copy link

UnsungHero97 commented Oct 22, 2016

will there be a new branch for the rewrite?

@joshwiens
Copy link
Contributor

@UnsungHero97 - I'm pretty sure the 2.0 work will be done on master. v1 Branch will be used for maintenance of the existing Karma Webpack release version.

@dignifiedquire
Copy link
Collaborator

@d3viant0ne master is currently void of any code, which is a bit odd. src/index.js is empty and index.js points to lib folder which is not checked into git.

@joshwiens
Copy link
Contributor

@dignifiedquire - #master is being completely rewritten. Legacy code & any current release / tags are on the v1 branch.

It's not something that could be merged down into master. Tagging a v1 branch was decided to be the path of least resistance.

@dignifiedquire
Copy link
Collaborator

Okay, thanks, might be good to have a warning though, as it is the default that people come in to and there is just nothing there anymore, it looks like it was an accident.

@joshwiens
Copy link
Contributor

@dignifiedquire - Most of the planning has been done in Slack. I'll put a note in the Readme on #master

@DanielaValero
Copy link

Hello @d3viant0ne @dignifiedquire I just opened a PR to add some documentation about the setup for contributors for the rewrite and added in the same PR also a note about the rewrite. PR is #185

@dignifiedquire
Copy link
Collaborator

Thank you @DanielaValero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants