Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SentimentUtils: Separate data and logic #4

Open
Chr1st1anSzech opened this issue Jun 11, 2017 · 1 comment
Open

SentimentUtils: Separate data and logic #4

Chr1st1anSzech opened this issue Jun 11, 2017 · 1 comment
Labels
enhancement

Comments

@Chr1st1anSzech
Copy link
Contributor

I would recommend to write all constants, words and other Information in ressource files, e.g. JSON or XML. That would support a more strict separation of data and logic. Furthermore, it simplifies i18n.
@codingupastorm
Copy link
Owner

Good idea - I wanted to first transcribe and make sure everything works but am happy to improve by moving the constants to resource files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chr1st1anSzech @codingupastorm