Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GetDetails -> GetDetail for consistency #110

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

kkweon
Copy link
Member

@kkweon kkweon commented Jun 23, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #110 (ac150d7) into main (adfeef3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files           4        4           
  Lines          86       86           
=======================================
  Hits           68       68           
  Misses         17       17           
  Partials        1        1           
Impacted Files Coverage Δ
server/pkg/serv/serv.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfeef3...ac150d7. Read the comment docs.

@nicewook
Copy link
Contributor

Details to Detail로 네이밍 변경으로 보이고 문제 없어 보입니다.

@kkweon kkweon enabled auto-merge (squash) June 23, 2021 08:08
Copy link
Contributor

@TangoEnSkai TangoEnSkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkweon kkweon merged commit 7914216 into main Jun 23, 2021
@kkweon kkweon deleted the fix-rename-get-detail branch June 23, 2021 18:27
@github-actions
Copy link

🎉 This PR is included in version 1.13.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants