Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Python 3.9 really required #212

Closed
symroe opened this issue Apr 14, 2022 · 1 comment · Fixed by #215
Closed

Is Python 3.9 really required #212

symroe opened this issue Apr 14, 2022 · 1 comment · Fixed by #215
Assignees

Comments

@symroe
Copy link
Contributor

symroe commented Apr 14, 2022

Hiya,

5.5.0 made Python 3.9 or greater a requirement. I understand keeping up with latest versions, but I don't think this codebase uses code that requires features in 3.9.

Python 3.8 is still commonly used and supported, and Django 3.2 (the oldest Django supported by this project) is still supporting back to Python 3.6.

Could you add 3.8 back in to CI and requirements? Or is there a good reason not to do this?

I'm happy to make the PR if it would help.

@codingjoe
Copy link
Owner

Hi @symroe,

Thanks for reaching out, before opening a PR. I run all my apps on 3.10, so I don't have any incentive to put in the work myself. Don't get me wrong, I don't mind you contributing 3.8 supports at all. I just have so many OSS packages to maintain, and to stay sane, I limit my contributions to my own interest. All that being said, be my guest. I might have used some 3.9 dictionary magic, that needs fixing as well, but that should be easy to spot. Good luck!

Best,
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants