Skip to content
This repository has been archived by the owner on Oct 2, 2018. It is now read-only.

Merge module system changes into develop #194

Closed
ferndot opened this issue Nov 1, 2014 · 5 comments
Closed

Merge module system changes into develop #194

ferndot opened this issue Nov 1, 2014 · 5 comments
Assignees

Comments

@ferndot
Copy link
Member

ferndot commented Nov 1, 2014

I was dumb, and pushed changes to the module system into the filesystem-2 branch. This action prevents the new module system from being used until that feature lands.

TODO: Separate all module-specific changes from the filesystem-2 branch, and merge them into the develop branch.

@ferndot
Copy link
Member Author

ferndot commented Nov 21, 2014

I am almost done with this. It is in the issue-194 branch.

@ferndot
Copy link
Member Author

ferndot commented Nov 23, 2014

@jackd1: I thought I merged all the changes, but file opening is not working. Could you check the code?

All I can deduce is that it works up to this line: https://github.com/codexa/firetext/blob/develop/scripts/firetext.js#L679

@ferndot ferndot mentioned this issue Nov 27, 2014
@ferndot
Copy link
Member Author

ferndot commented Nov 27, 2014

I created a pull request for this fix. It is #221.

Thank you @twiss for your help =)

twiss added a commit that referenced this issue Nov 27, 2014
@ferndot
Copy link
Member Author

ferndot commented Nov 29, 2014

I will rebase filesystem-2 to point to develop presently.

@ferndot
Copy link
Member Author

ferndot commented Nov 29, 2014

Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant