feat(noteList): added page parameter and portionSize constant #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
e11sy
commented
Oct 22, 2023
•
e11sy
commented
- added parameter for getNoteListByCreatorId func
- added portionSize constant for noteList in service
* added offset and limit parameters for getNoteListByCreatorId func
|
Maybe page and count? |
neSpecc
reviewed
Oct 22, 2023
*added constant portipnSize insead of variable limit *added page *offset is now calculated by page
parameters logic in comments fixed
neSpecc
approved these changes
Oct 22, 2023
Co-authored-by: Peter Savchenko <[email protected]>
Co-authored-by: Peter Savchenko <[email protected]>
e11sy
changed the title
e11sy
changed the title
lint fixes
…m/notes.api into noteList(offset_limit)
GeekaN2
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.