Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Manuel is falsely reported #3202

Closed
georgkrause opened this issue Nov 7, 2023 · 4 comments · Fixed by #3204
Closed

Name Manuel is falsely reported #3202

georgkrause opened this issue Nov 7, 2023 · 4 comments · Fixed by #3204
Labels
dictionary Changes to the dictionary

Comments

@georgkrause
Copy link

Since the latest version codespell tries falsely reports our Developer Manuel to be written wrong and tries to correct this to manual.

I am not sure if a common name should be included in the data as a wrong spelling.

@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Nov 7, 2023
@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Nov 7, 2023

Yes, I've seen that myself today in pandas.

What can I say? Lots of typos might be actual names of places or people in different cultures. See for example #2812. It's a thin line between having no false positives but but lots of false negatives, and having fewer false negatives at the expense of more false positives. I would even acknowledge a cultural bias: proper nouns outside the traditional English-speaking cultural sphere may be at a disadvantage. I don't have an easy solution to suggest. In this specific case, perhaps we could move manuel to the rare dictionary, but then the name Manuel is not rare. I've seen collisions between a typo and a name in many large projects, they are usually handled by adding the specific typo to the list of words to ignore.

@peternewman
Copy link
Collaborator

We've a dictionary for that already, the names one, we just need to move it to there:
https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary_names.txt

@DimitriPapadopoulos
Copy link
Collaborator

I hadn't noticed this small dictionary, thank you for poiting us to it.

@georgkrause A PR moving manuel to the names dictionary would be most welcome.

@hugovk
Copy link
Contributor

hugovk commented Nov 8, 2023

Please see PR #3204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants