-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff checks failing on master
#2960
Comments
Opened a separate issue to discuss a potential long-term solution for this and similar issues: |
Indeed ruff is still evolving rapidly resulting in new CI alerts without actual changes in our codebase (see for example #2796, #2802 or #2834). You just need to change:
to:
I had already tried to limit the number of branches in #2767, just to please ruff, resulting in artificial and useless changes, more complex code, or even hard to spot regressions. Ended up bumping Or, alternatively, you can reorganise the code to remove branches, although I don't see anything wrong with multiple similar branches when parsing command line options. Or perhaps you can add a |
It appears something's changed with the latest version of ruff, causing the server-side checks to fail with the following output:
I was able to recreate this locally.
v0.0.254
of the Pre-Commit hook passes all checks, but the latest version,v0.0.280
, raises the same error.The text was updated successfully, but these errors were encountered: