You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"Inspired" by #2765 where I suggested to remove whet from dictionary_rare. A valid comment from @DimitriPapadopoulos was
The idea is that you don't let codespell fix typos blindly.
which I agree with but even with non-blind review of the changes (e.g. in >100 files) it is hard to spot false positives. In case of rare, but legit words, one way to accent on their legitimacy but "oddity" is to list them as choices as well. That would 1. force user interaction, 2. ensure that correct original form is given as a choice (although then user also should add that skip to the config file for future runs).
Without such explicit listing and interaction in cases with words which have only 1 other correct choice, such as wit - if someone runs codespell -w -- they would be applied automagically without interaction
❯ cat SAMPLE.md
Whet my appetite and train my wit.
❯ codespell SAMPLE.md
SAMPLE.md:1: Whet ==> When, What, Wet
SAMPLE.md:1: wit ==> with
so in the case of whet I at least avoid automated fixing since have multiple choices, but in case of wit, if apply automagic fixing -- it would be fixed into incorrect with.
The text was updated successfully, but these errors were encountered:
yarikoptic
changed the title
make rare demanding user interaction and have themselves given as a choice?
make rare words demand user interaction and have themselves given as a choice
Mar 3, 2023
"Inspired" by #2765 where I suggested to remove
whet
fromdictionary_rare
. A valid comment from @DimitriPapadopoulos waswhich I agree with but even with non-blind review of the changes (e.g. in >100 files) it is hard to spot false positives. In case of rare, but legit words, one way to accent on their legitimacy but "oddity" is to list them as choices as well. That would 1. force user interaction, 2. ensure that correct original form is given as a choice (although then user also should add that skip to the config file for future runs).
Without such explicit listing and interaction in cases with words which have only 1 other correct choice, such as
wit
- if someone runscodespell -w
-- they would be applied automagically without interactionso in the case of
whet
I at least avoid automated fixing since have multiple choices, but in case ofwit
, if apply automagic fixing -- it would be fixed into incorrectwith
.The text was updated successfully, but these errors were encountered: