Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codespell toml parsing with python 3.11 #2713

Closed
lovetox opened this issue Jan 17, 2023 · 2 comments · Fixed by #2715
Closed

codespell toml parsing with python 3.11 #2713

lovetox opened this issue Jan 17, 2023 · 2 comments · Fixed by #2715
Labels
bug

Comments

@lovetox
Copy link

lovetox commented Jan 17, 2023 •
edited
Loading

Hi,

this seems not to work currently.

the pyproject.toml

toml = [
    "tomli; python_version < '3.11'"
]

but without tomli nothing will be parsed, because nowhere the python 3.11 stdlib tomlib gets imported and used.
@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Jan 17, 2023
Merged
@DimitriPapadopoulos
Copy link
Collaborator

Does #2715 help?

@lovetox
Copy link
Author

lovetox commented Jan 17, 2023

i cant test right now, but code looks good.

@neiljp neiljp mentioned this issue Feb 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve support of TOML config files DimitriPapadopoulos/codespell
2 participants
@DimitriPapadopoulos @lovetox