Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding ploted ==> plotted to dictionary #2340

Closed
matthewfeickert opened this issue May 4, 2022 · 3 comments · Fixed by #2341
Closed

Consider adding ploted ==> plotted to dictionary #2340

matthewfeickert opened this issue May 4, 2022 · 3 comments · Fixed by #2341
Labels
dictionary Changes to the dictionary

Comments

@matthewfeickert
Copy link
Contributor

Hi. 👋 As noticed in matplotlib/matplotlib#22777 (comment) codespell v2.1.0 doesn't catch ploted as being a typo of plotted. Would you consider a PR that adds

ploted->plotted

to one of the dictionaries (probably codespell_lib/data/dictionary.txt)?

@luzpaz
Copy link
Collaborator

luzpaz commented May 4, 2022

Feel free to submit a PR for this

@matthewfeickert
Copy link
Contributor Author

@luzpaz will do. 👍 In the future, what's the dev team's preferred way of iterating on questions like this: to have people open up Issues for each addition, or to have people just open PRs if the changes seem "uncontroversial" and then close them if the dev team think the changes don't benefit the project?

@peternewman
Copy link
Collaborator

@luzpaz will do. 👍 In the future, what's the dev team's preferred way of iterating on questions like this: to have people open up Issues for each addition, or to have people just open PRs if the changes seem "uncontroversial" and then close them if the dev team think the changes don't benefit the project?

Hi @matthewfeickert ,

Yeah just go straight for a PR, and feel free to put a few changes together in one PR if you'd like, although more than about 20 often gets a bit unwieldy with finding issues on some bits and them blocking others.

I wouldn't generally bother with an issue about a single entry, but perhaps about a more general thing say, or a lot of bulk changes. Or I suppose anything that involves a lot of work to generate the PR for and could potentially be controversial (say adding plurals for everything that's missing them), just in case it got rejected so the work wasn't wasted. Although equally you could open a sample PR with a few for an initial review.

But generally just go straight for a PR if it's just a dictionary change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants