-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong string detection with version 1.15.0 and 1.16.0 #1251
Comments
I think that's expected, this system doesn't currently inspect the code, so doesn't realise you're quoting a string and hence assumes you've got an errant apostrophe. |
Then why it was working in version 1.14.0? |
Because that correction was only added in the change between the two:
Yes, you can whitelist either specific lines or corrections, see the man pages/help for Codespell. |
OK, thanks :-) |
Sounds like this is resolved enough, closing |
It's not fixed I just found a workaround... |
I think a proper fix for this would need a full code parser for example you can't just check if there is a preceding single quote due to scenarios like this where it should flag the issue:
|
With a js file like that
I get the error:
The text was updated successfully, but these errors were encountered: