fix(client): enable code-splitting and dynamic imports in esbuild

[danilowoz]

All kudos to @jeetiss

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
sandpack-docs	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 20, 2023 at 4:03PM (UTC)

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d39c13e:

Sandbox	Source
Sandpack	Configuration

[jeetiss]

this PR fixes only esm entries so commonjs still can cause bugs and code duplication because @codesandbox/sandpack-client/clients/node and @codesandbox/sandpack-client/clients/runtime is bundled into @codesandbox/sandpack-client

const { loadSandpackClient } = require("@codesandbox/sandpack-client");
const { SandpackRuntime } = require("@codesandbox/sandpack-client/clients/runtime");

(async () => {
  const client = await loadSandpackClient("div > iframe", {});
  console.log(client instanceof SandpackRuntime);
  // ^ will be false for commonjs but should be true
})();

sandbox

[danilowoz]

Well, esbuild says "Splitting currently only works with the "esm" format"
#753

[jeetiss]

Yes, this is impossible to fix with esbuild. it is a tool limitation