fix(sandpack-client): fixing package exports #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- skip `utils.ts` and `utils.test.ts`
- this option enables dynamic import in `esm` and reuse `clients/runtime` and `clients/node` entries
|
@jeetiss is attempting to deploy a commit to the CodeSandbox Team on Vercel. A member of the Team first needs to authorize it. |
danilowoz
reviewed
Feb 20, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Split this PR on bundler changes: #741 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f1ab867:
|
|
Sorry, @jeetiss, for hijacking your PR, but I took this time to fix the export and another issue too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
Fixes package exports again and enable code-splitting and dynamic imports in
esbuilddocs: https://esbuild.github.io/api/#splitting
fix #724
fix #677