Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a new sandbox theme #616

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

VedanthB
Copy link
Contributor

What kind of change does this pull request introduce?

This is a feature.

What is the current behavior?

#596

What is the new behavior?

This adds a new sandbox theme

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

NA

Checklist

  • Documentation; NA
  • Storybook (if applicable); NA
  • Tests; NA
  • Ready to be merged;

@codesandbox
Copy link

codesandbox bot commented Oct 14, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Storybook

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e07217:

Sandbox Source
Sandpack Configuration

@danilowoz
Copy link
Member

Hey, thanks for contributing to the themes!

However, could you make some tweaks to improve the legibility of the nav bar? Once it's done, I think it's ready to go
Screenshot 2022-10-14 at 09 14 52

@VedanthB
Copy link
Contributor Author

Hey, thanks for contributing to the themes!

However, could you make some tweaks to improve the legibility of the nav bar? Once it's done, I think it's ready to go Screenshot 2022-10-14 at 09 14 52

HI , I have made changes, please review.

@danilowoz
Copy link
Member

🎉

@danilowoz danilowoz merged commit 0cc7567 into codesandbox:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants