feat(theme): EcoLight theme #602
Conversation
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 695cf5a:
|
| @@ -0,0 +1,36 @@ | |||
| import type { SandpackTheme } from "./types"; | |||
|
|
|||
| export const danielAwesomePro: SandpackTheme = { | |||
There was a problem hiding this comment.
Hey @D-Lite, thanks for your awesome contribution!
Your theme looks good, but I just want to point one tweak here. Every Sandpack Theme usually have a name that represents its styling or a proper name, examples: githubLight, atomDark, etc.
So, in order to go further and merging it, I'd like to ask to rename it to something that represents the theme and not the author name or generic names such as awesome and pro that don't represent very well the theme itself.
There was a problem hiding this comment.
Hi @danilowoz
This has been resolved and I just made a new commit!
There was a problem hiding this comment.
I think you forgot to push your changes, because I can't see it on the diff
There was a problem hiding this comment.
@danilowoz, I had to push and make changes manually
Now you can see the diff.
|
Thank you @danilowoz and Ace_kyd PR merged! |
What kind of change does this pull request introduce?
My changes illustrated the addition of a new custom theme with guidance from ace_kyd following this this tutorial
Excited to contribute to open source this year!
