fix(codemirror): avoid Escape keybinding conflict

[danilowoz]

Solves https://github.com/codesandbox/sandpack/discussions/576
Solves #582

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Storybook

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e3b4a69:

Sandbox	Source
Sandpack	Configuration
sandpack-with-codemirror-vim	Configuration

[danilowoz]

Thanks @hawkup, for providing an example. I managed to fix it by prioritizing the extensions keybinding over the internal ones, could you please test it and make sure it's working as you expected?

https://codesandbox.io/s/sandpack-with-codemirror-vim-7g465c

[github-actions]

Size changes

sandpack-react

Total base (gzip)	Total current (gzip)	+/-
181 kb	181 kb	🎉 -70 bytes (-0.04%)

Details

Dependency name / file	Base	Current	+/-
0	522 kb	522 kb	✅ 0 byte
main	544 kb	544 kb	🎉 -309 bytes (-0.06%)
@codesandbox/sandpack-react	86 kb	86 kb	🎉 -309 bytes (-0.35%)
@code-hike/classer	1 kb	1 kb	✅ 0 byte
@codesandbox/sandpack-client	8 kb	8 kb	✅ 0 byte
@stitches/core	16 kb	16 kb	✅ 0 byte
@codemirror/state	35 kb	35 kb	✅ 0 byte
@codemirror/view	167 kb	167 kb	✅ 0 byte
@codemirror/closebrackets	6 kb	6 kb	✅ 0 byte
@codemirror/matchbrackets	4 kb	4 kb	✅ 0 byte
@codemirror/commands	24 kb	24 kb	✅ 0 byte
@codemirror/comment	5 kb	5 kb	✅ 0 byte
@codemirror/gutter	10 kb	10 kb	✅ 0 byte
@codemirror/highlight	12 kb	12 kb	✅ 0 byte
@codemirror/history	9 kb	9 kb	✅ 0 byte
@react-hook/intersection-observer	2 kb	2 kb	✅ 0 byte
@codemirror/lang-css	11 kb	11 kb	✅ 0 byte
@codemirror/lang-javascript	6 kb	6 kb	✅ 0 byte
@codemirror/lang-html	15 kb	15 kb	✅ 0 byte
@codemirror/lang-markdown	9 kb	9 kb	✅ 0 byte
clean-set	229 bytes	229 bytes	✅ 0 byte
@codemirror/text	13 kb	13 kb	✅ 0 byte
style-mod	3 kb	3 kb	✅ 0 byte
@codemirror/rangeset	16 kb	16 kb	✅ 0 byte
w3c-keyname	2 kb	2 kb	✅ 0 byte
@lezer/common	34 kb	34 kb	✅ 0 byte
@codemirror/language	19 kb	19 kb	✅ 0 byte
@react-hook/passive-layout-effect	191 bytes	191 bytes	✅ 0 byte
@lezer/css	9 kb	9 kb	✅ 0 byte
@lezer/html	12 kb	12 kb	✅ 0 byte
@lezer/javascript	54 kb	54 kb	✅ 0 byte
@codemirror/autocomplete	34 kb	34 kb	✅ 0 byte
@lezer/markdown	42 kb	42 kb	✅ 0 byte
@lezer/lr	31 kb	31 kb	✅ 0 byte
@codemirror/tooltip	14 kb	14 kb	✅ 0 byte
lodash.isequal	18 kb	18 kb	✅ 0 byte
lz-string	9 kb	9 kb	✅ 0 byte
react-devtools-inline	823 kb	823 kb	✅ 0 byte
codesandbox-import-utils	3 kb	3 kb	✅ 0 byte
package-build-stats	487 bytes	487 bytes	✅ 0 byte
intersection-observer	13 kb	13 kb	✅ 0 byte
react-is	2 kb	2 kb	✅ 0 byte

sandpack-client

Total base (gzip)	Total current (gzip)	+/-
7 kb	7 kb	✅ 0 byte

Details

Dependency name / file	Base	Current	+/-
main	20 kb	20 kb	✅ 0 byte
@codesandbox/sandpack-client	8 kb	8 kb	✅ 0 byte
codesandbox-import-utils	3 kb	3 kb	✅ 0 byte
lodash.isequal	18 kb	18 kb	✅ 0 byte
package-build-stats	487 bytes	487 bytes	✅ 0 byte

[hawkup]

@danilowoz it works like my expectation. Thank you so much.