Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 peer dependency #526

Closed
1 of 2 tasks
StefanoMagrassi opened this issue Jul 1, 2022 · 0 comments · Fixed by #529
Closed
1 of 2 tasks

React 18 peer dependency #526

StefanoMagrassi opened this issue Jul 1, 2022 · 0 comments · Fixed by #529
Labels
bug Something isn't working triage New issues that needs consideration

Comments

@StefanoMagrassi
Copy link

Bug report

Packages affected

  • sandpack-client
  • sandpack-react

Description of the problem

The PR #375, which should had fixed the issue #459, set the React version to 18 (at least for the @types package), but did not update the version in the peerDependencies object which causes the already mentioned ERESOLVE unable to resolve dependency tree error (both for react and react-dom packages)

What were you doing when the problem occurred?

Installing the @codesandbox/sandpack-react package

What steps can we take to reproduce the problem?

Create and empty npm package with React 18 as dependency and then try to install the @codesandbox/sandpack-react package

Your Environment

Software Name/Version
Sandpack-client version
Sandpack-react version 1.2.2
Browser
Operating System Linux
@StefanoMagrassi StefanoMagrassi added bug Something isn't working triage New issues that needs consideration labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New issues that needs consideration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant