-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(file-explorer): adds property not to show hidden files #488
fix(file-explorer): adds property not to show hidden files #488
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1226518:
|
Thanks, @jerrywu001 for fixing this issue! I took this change to refactor the class component to functional components and add some tests. Let me know what you think about these changes. |
@jerrywu001 what if we rename it from |
Thanks, understand. What should I do next? |
Then it's ready to go! |
Your changes are perfect, there is no need to review the PR. |
How to pass the following checks🤣🤣🤣
|
I believe it's because your user doesn't have write access to this repo, and then these actions can't perform some operations. But it's fine, don't worry |
What kind of change does this pull request introduce?
provide a property(enableAutoHiddenFile: default value is false) in FIleExplorer Component that indicates whether files in the file tree are automatically hidden.
What is the current behavior?
Closes #482
What is the new behavior?
My solution is to provide a property that indicates whether files in the file tree are automatically hidden.LIke this:
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
add story: http://localhost:6006/?path=/story/bug-reports-issues--issue-482
Checklist