Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update code mirror 0.20 #468

Closed
1 task
sheeeeep opened this issue May 19, 2022 · 2 comments · Fixed by #679
Closed
1 task

update code mirror 0.20 #468

sheeeeep opened this issue May 19, 2022 · 2 comments · Fixed by #679
Labels
triage New issues that needs consideration

Comments

@sheeeeep
Copy link

sheeeeep commented May 19, 2022 •
edited
Loading

Tell us how you think we can improve Sandpack

Packages affected

  • sandpack-react

What is this feature?

update code mirror 0.20

How would your idea work?

I have other code editor in my project, which use 0.20. They made conflicts and errors.
@sheeeeep sheeeeep added feature:request triage New issues that needs consideration labels May 19, 2022
@danilowoz
Copy link
Member

I tried to upgrade all CodeMirror dependencies, but I faced a few problems, probably due to some breaking changes. If you can, I recommend trying to match the Sandpack dependencies version.

In the future, I'll try to spend more time addressing it.

@sheeeeep
Copy link
Author

Thanks.
Hope you can upgrade it as soon as possible, because I can't get useful help from CM6's doc when using old version.

@danilowoz danilowoz mentioned this issue Dec 19, 2022
Closed
2 tasks
@danilowoz danilowoz mentioned this issue Jan 9, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage New issues that needs consideration
Projects
None yet
Milestone
No milestone
2 participants
@danilowoz @sheeeeep