fix(editor): prefer useId when available #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
May 6, 2022
| @@ -125,7 +125,10 @@ export const CodeMirror = React.forwardRef<CodeMirrorRef, CodeMirrorProps>( | |||
|
|
|||
| const c = useClasser("sp"); | |||
| const { listen } = useSandpack(); | |||
| const ariaId = React.useRef<string>(id ?? generateRandomId()); | |||
There was a problem hiding this comment.
Note sure if the "passed-in ID" use case is important.
There was a problem hiding this comment.
Initially, the purpose of the id props is to get consistent ids in snapshot tests. But I guess useId will always return a constant value, right?
There was a problem hiding this comment.
As long as you don't change the parent component path. If you do, the snapshot will update.
danilowoz
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 76fc29a:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't actually tested but we need to do this. I see mismatches otherwise.
I tried to keep it backwards-compatible. If you drop 17 support then you can just useId.