Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readonly): toggle remounting #456

Merged
merged 2 commits into from
May 2, 2022
Merged

fix(readonly): toggle remounting #456

merged 2 commits into from
May 2, 2022

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented May 2, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

Closes #454

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bccb414:

Sandbox Source
Sandpack Blog Example 1 Configuration

@github-actions
Copy link

github-actions bot commented May 2, 2022

Size changes

sandpack-react

Total base (gzip) Total current (gzip) +/-
161 kb 161 kb 🎉 -232 bytes (-0.14%)
Details
Dependency name / file Base Current +/-
0 522 kb 522 kb ✅ 0 byte
main 457 kb 456 kb 🎉 -1 kb (-0.26%)
index.css 27 kb 27 kb ✅ 0 byte
@codesandbox/sandpack-react 72 kb 71 kb 🎉 -1 kb (-1.96%)
@code-hike/classer 1 kb 1 kb ✅ 0 byte
@codesandbox/sandpack-client 11 kb 11 kb ✅ 0 byte
@codemirror/state 35 kb 35 kb ✅ 0 byte
@codemirror/view 167 kb 167 kb ✅ 0 byte
@codemirror/closebrackets 6 kb 6 kb ✅ 0 byte
@codemirror/matchbrackets 4 kb 4 kb ✅ 0 byte
@codemirror/commands 24 kb 24 kb ✅ 0 byte
@codemirror/comment 5 kb 5 kb ✅ 0 byte
@codemirror/gutter 10 kb 10 kb ✅ 0 byte
@codemirror/highlight 12 kb 12 kb ✅ 0 byte
@codemirror/history 9 kb 9 kb ✅ 0 byte
@react-hook/intersection-observer 2 kb 2 kb ✅ 0 byte
@codemirror/lang-css 11 kb 11 kb ✅ 0 byte
@codemirror/lang-javascript 6 kb 6 kb ✅ 0 byte
@codemirror/lang-html 15 kb 15 kb ✅ 0 byte
@codemirror/text 13 kb 13 kb ✅ 0 byte
style-mod 3 kb 3 kb ✅ 0 byte
@codemirror/rangeset 16 kb 16 kb ✅ 0 byte
w3c-keyname 2 kb 2 kb ✅ 0 byte
@lezer/common 34 kb 34 kb ✅ 0 byte
@codemirror/language 19 kb 19 kb ✅ 0 byte
@react-hook/passive-layout-effect 191 bytes 191 bytes ✅ 0 byte
@lezer/css 9 kb 9 kb ✅ 0 byte
@lezer/html 12 kb 12 kb ✅ 0 byte
@lezer/javascript 54 kb 54 kb ✅ 0 byte
@codemirror/autocomplete 34 kb 34 kb ✅ 0 byte
@lezer/lr 31 kb 31 kb ✅ 0 byte
@codemirror/tooltip 14 kb 14 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
lz-string 9 kb 9 kb ✅ 0 byte
react-devtools-inline 823 kb 823 kb ✅ 0 byte
codesandbox-import-utils 3 kb 3 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte
intersection-observer 13 kb 13 kb ✅ 0 byte
react-is 2 kb 2 kb ✅ 0 byte

sandpack-client

Total base (gzip) Total current (gzip) +/-
7 kb 7 kb 🎉 -8 bytes (-0.11%)
Details
Dependency name / file Base Current +/-
main 21 kb 21 kb 🎉 -25 bytes (-0.12%)
@codesandbox/sandpack-client 11 kb 11 kb 🎉 -25 bytes (-0.22%)
codesandbox-import-utils 3 kb 3 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte

@danilowoz danilowoz force-pushed the draft/ecstatic-einstein branch from 01abc47 to bccb414 Compare May 2, 2022 09:46
@danilowoz danilowoz requested a review from DeMoorJasper May 2, 2022 09:46
@danilowoz danilowoz merged commit b4162bc into main May 2, 2022
@danilowoz danilowoz deleted the draft/ecstatic-einstein branch May 2, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling readOnly prop of SandpackCodeEditor breaks editor
1 participant