Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow devDependencies prop inside of customSetup object #434

Closed
1 of 2 tasks
cliffordfajardo opened this issue Apr 11, 2022 · 1 comment · Fixed by #436
Closed
1 of 2 tasks

Allow devDependencies prop inside of customSetup object #434

cliffordfajardo opened this issue Apr 11, 2022 · 1 comment · Fixed by #436
Labels
triage New issues that needs consideration

Comments

@cliffordfajardo
Copy link

cliffordfajardo commented Apr 11, 2022

Tell us how you think we can improve Sandpack

Packages affected

  • sandpack-client
  • sandpack-react

What is this feature?

Allow users to pass a devDependencies object similar to dependencies with is supported by the customSetup object

CleanShot 2022-04-11 at 07 03 11@2x

Motivation for this feature

  • Sometimes a user is using npm packages that don't have typescript types bundled with the library, so a user has to go to find the @types/... packages on npm
  • sometimes a user might want to open a sandpack preview with the "open in codesanbox" button and when they load the package, they might see lots of red warnings because types are missing

From a user perspective, my first reaction to seeing that devDependencies wasn't allowed as a prop is: Why? so i think other might also have that reaction too, perhaps they haven't voiced it and spent the time to write about it on here

References

@cliffordfajardo
Copy link
Author

cliffordfajardo commented Apr 12, 2022

Thanks for #436! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issues that needs consideration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant