Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preview): additional content in preview container #422

Merged
merged 6 commits into from
Mar 27, 2022

Conversation

PeterDraex
Copy link
Contributor

@PeterDraex PeterDraex commented Mar 25, 2022

What kind of change does this pull request introduce?

New feature

What is the new behavior?

Children of <SandpackPreview> are rendered at the end of div.sp-preview-container.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Used in a documentation site.

Checklist

  • Documentation;
  • Storybook (if applicable);
  • Tests;
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f60289:

Sandbox Source
Sandpack Blog Example 1 Configuration

@danilowoz danilowoz changed the title Additional content in preview container feat(preview): additional content in preview container Mar 25, 2022
@PeterDraex PeterDraex requested a review from danilowoz March 26, 2022 11:01
@PeterDraex
Copy link
Contributor Author

Ready to merge in my opinion

@danilowoz danilowoz merged commit 98103a8 into codesandbox:main Mar 27, 2022
@PeterDraex PeterDraex deleted the preview-content branch March 30, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants