-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(loglevel): set default #418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
requested changes
Mar 18, 2022
danilowoz
force-pushed
the
feat/log-level
branch
2 times, most recently
from
March 18, 2022 14:53
7e3bc46
to
4eefa79
Compare
danilowoz
force-pushed
the
feat/log-level
branch
from
March 18, 2022 14:55
7e3bc46
to
4eefa79
Compare
DeMoorJasper
approved these changes
Mar 18, 2022
DeMoorJasper
approved these changes
Mar 18, 2022
Size changessandpack-react
Details
sandpack-client
Details
|
danilowoz
force-pushed
the
feat/log-level
branch
from
March 18, 2022 15:07
59c0ea7
to
4eefa79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open in CodeSandbox Web Editor | VS Code
It provides a default value for the
logLevel
on sandpack-client. I see many unexpected logs coming from the bundler that we can't rid of. @DeMoorJasper if someone setlogLevel
to none, will they still receive these logs through iframe-protocol?