Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loglevel): set default #418

Merged
merged 2 commits into from
Mar 18, 2022
Merged

fix(loglevel): set default #418

merged 2 commits into from
Mar 18, 2022

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented Mar 18, 2022

CodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

It provides a default value for the logLevel on sandpack-client. I see many unexpected logs coming from the bundler that we can't rid of. @DeMoorJasper if someone set logLevel to none, will they still receive these logs through iframe-protocol?

@danilowoz danilowoz requested a review from DeMoorJasper March 18, 2022 11:14
@codesandbox codesandbox deleted a comment from codesandbox-ci bot Mar 18, 2022
sandpack-client/src/client.ts Outdated Show resolved Hide resolved
@codesandbox codesandbox deleted a comment from github-actions bot Mar 18, 2022
@danilowoz danilowoz force-pushed the feat/log-level branch 2 times, most recently from 7e3bc46 to 4eefa79 Compare March 18, 2022 14:53
@codesandbox codesandbox deleted a comment from github-actions bot Mar 18, 2022
@danilowoz danilowoz requested a review from DeMoorJasper March 18, 2022 15:00
@codesandbox codesandbox deleted a comment from github-actions bot Mar 18, 2022
@github-actions
Copy link

github-actions bot commented Mar 18, 2022

Size changes

sandpack-react

Total base (gzip) Total current (gzip) +/-
160 kb 160 kb ✅ 0 byte
Details
Dependency name / file Base Current +/-
0 522 kb 522 kb ✅ 0 byte
main 455 kb 455 kb ✅ 0 byte
index.css 27 kb 27 kb ✅ 0 byte
@codesandbox/sandpack-react 70 kb 70 kb ✅ 0 byte
@code-hike/classer 1 kb 1 kb ✅ 0 byte
@codesandbox/sandpack-client 13 kb 13 kb ✅ 0 byte
@codemirror/state 35 kb 35 kb ✅ 0 byte
@codemirror/view 167 kb 167 kb ✅ 0 byte
@codemirror/closebrackets 6 kb 6 kb ✅ 0 byte
@codemirror/matchbrackets 4 kb 4 kb ✅ 0 byte
@codemirror/commands 24 kb 24 kb ✅ 0 byte
@codemirror/comment 5 kb 5 kb ✅ 0 byte
@codemirror/gutter 10 kb 10 kb ✅ 0 byte
@codemirror/highlight 12 kb 12 kb ✅ 0 byte
@codemirror/history 9 kb 9 kb ✅ 0 byte
@react-hook/intersection-observer 2 kb 2 kb ✅ 0 byte
@codemirror/lang-css 11 kb 11 kb ✅ 0 byte
@codemirror/lang-javascript 6 kb 6 kb ✅ 0 byte
@codemirror/lang-html 15 kb 15 kb ✅ 0 byte
@codemirror/text 13 kb 13 kb ✅ 0 byte
style-mod 3 kb 3 kb ✅ 0 byte
@codemirror/rangeset 16 kb 16 kb ✅ 0 byte
w3c-keyname 2 kb 2 kb ✅ 0 byte
@lezer/common 34 kb 34 kb ✅ 0 byte
@codemirror/language 19 kb 19 kb ✅ 0 byte
@react-hook/passive-layout-effect 191 bytes 191 bytes ✅ 0 byte
@lezer/css 9 kb 9 kb ✅ 0 byte
@lezer/html 12 kb 12 kb ✅ 0 byte
@lezer/javascript 54 kb 54 kb ✅ 0 byte
@codemirror/autocomplete 34 kb 34 kb ✅ 0 byte
@lezer/lr 31 kb 31 kb ✅ 0 byte
@codemirror/tooltip 14 kb 14 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
codesandbox-import-utils 367 bytes 367 bytes ✅ 0 byte
react-devtools-inline 823 kb 823 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte
intersection-observer 13 kb 13 kb ✅ 0 byte
lz-string 9 kb 9 kb ✅ 0 byte
react-is 2 kb 2 kb ✅ 0 byte

sandpack-client

Total base (gzip) Total current (gzip) +/-
7 kb 7 kb ⚠️ +12 bytes (+0.16%)
Details
Dependency name / file Base Current +/-
main 20 kb 20 kb ⚠️ +21 bytes (+0.10%)
@codesandbox/sandpack-client 11 kb 11 kb ⚠️ +39 bytes (+0.35%)
codesandbox-import-utils 3 kb 3 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte

@danilowoz danilowoz requested a review from DeMoorJasper March 18, 2022 15:11
@danilowoz danilowoz merged commit abf0243 into main Mar 18, 2022
@danilowoz danilowoz deleted the feat/log-level branch March 18, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants