Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add slot for additional buttons #412

Merged
merged 10 commits into from
Mar 16, 2022
Merged

Conversation

PeterDraex
Copy link
Contributor

What kind of change does this pull request introduce?

This PR enables users to add more buttons to the preview area. They will be rendered right before buttons for "Refresh" and "Open in CodeSandbox".

What is the current behavior?

Users can't add custom buttons to preview.

What is the new behavior?

User can add a button in the following way:

<SandpackPreview
    additionalButtons={
      <button
        className="sp-button"
        style={{ padding: 'var(--sp-space-1) var(--sp-space-3)' }}
        onClick={() => window.alert('Bug reported!')}>
        Report bug
      </button>
    }
  />

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Manually tested in the documentation and in a personal project.

Checklist

  • Documentation
  • Tests
  • Ready to be merged

@PeterDraex PeterDraex changed the title Add slot for more actions Add slot for more additional buttons Mar 15, 2022
@PeterDraex PeterDraex changed the title Add slot for more additional buttons Add slot for additional buttons Mar 15, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4987877:

Sandbox Source
Sandpack Blog Example 1 Configuration

@PeterDraex PeterDraex requested a review from danilowoz March 15, 2022 14:42
@PeterDraex PeterDraex changed the title Add slot for additional buttons feat: Add slot for additional buttons Mar 15, 2022
@PeterDraex PeterDraex requested a review from danilowoz March 15, 2022 18:30
@danilowoz
Copy link
Member

🚀 Thanks a lot @PeterDraex, awesome work here!

@danilowoz danilowoz merged commit 7a59d18 into codesandbox:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants