Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logLevel to sandpack options #378

Merged
merged 1 commit into from
Feb 18, 2022
Merged

feat: Add logLevel to sandpack options #378

merged 1 commit into from
Feb 18, 2022

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Feb 18, 2022

What kind of change does this pull request introduce?

New feature: log levels, introduced in the new bundler to make debugging easier, without having to spam the console all the time or explain undocumented hacks with localstorage and queryparams

What is the current behavior?

There is no way to change the log level from sandpack itself, this is configured mostly using hacks in localstorage or query params

What is the new behavior?

Log level is specified via the options of sandpack (currently only works for the new bundler)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 81b86ef:

Sandbox Source
Sandpack Blog Example 1 Configuration

@github-actions
Copy link

github-actions bot commented Feb 18, 2022

Size changes

sandpack-react

Total base (gzip) Total current (gzip) +/-
161 kb 161 kb ✅ 0 byte
Details
Dependency name / file Base Current +/-
0 522 kb 522 kb ✅ 0 byte
main 455 kb 456 kb ✅ 0 byte
index.css 28 kb 28 kb ✅ 0 byte
@codesandbox/sandpack-react 73 kb 73 kb ✅ 0 byte
@code-hike/classer 1 kb 1 kb ✅ 0 byte
@codesandbox/sandpack-client 13 kb 13 kb ✅ 0 byte
@codemirror/state 35 kb 35 kb ✅ 0 byte
@codemirror/view 164 kb 164 kb ✅ 0 byte
@codemirror/closebrackets 6 kb 6 kb ✅ 0 byte
@codemirror/matchbrackets 4 kb 4 kb ✅ 0 byte
@codemirror/commands 24 kb 24 kb ✅ 0 byte
@codemirror/comment 4 kb 5 kb ✅ 0 byte
@codemirror/gutter 10 kb 10 kb ✅ 0 byte
@codemirror/highlight 12 kb 12 kb ✅ 0 byte
@codemirror/history 9 kb 9 kb ✅ 0 byte
@react-hook/intersection-observer 2 kb 2 kb ✅ 0 byte
@codemirror/lang-css 11 kb 11 kb ✅ 0 byte
@codemirror/lang-javascript 6 kb 6 kb ✅ 0 byte
@codemirror/lang-html 15 kb 15 kb ✅ 0 byte
@codemirror/text 13 kb 13 kb ✅ 0 byte
style-mod 3 kb 3 kb ✅ 0 byte
@codemirror/rangeset 16 kb 16 kb ✅ 0 byte
w3c-keyname 2 kb 2 kb ✅ 0 byte
@lezer/common 33 kb 33 kb ✅ 0 byte
@codemirror/language 19 kb 19 kb ✅ 0 byte
@react-hook/passive-layout-effect 191 bytes 191 bytes ✅ 0 byte
@lezer/css 9 kb 9 kb ✅ 0 byte
@lezer/html 12 kb 12 kb ✅ 0 byte
@lezer/javascript 54 kb 54 kb ✅ 0 byte
@codemirror/autocomplete 33 kb 34 kb ✅ 0 byte
@lezer/lr 31 kb 31 kb ✅ 0 byte
@codemirror/tooltip 14 kb 14 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
codesandbox-import-utils 367 bytes 367 bytes ✅ 0 byte
react-devtools-inline 823 kb 823 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte
intersection-observer 13 kb 13 kb ✅ 0 byte
lz-string 9 kb 9 kb ✅ 0 byte
react-is 2 kb 2 kb ✅ 0 byte

sandpack-client

Total base (gzip) Total current (gzip) +/-
7 kb 7 kb ✅ 0 byte
Details
Dependency name / file Base Current +/-
main 20 kb 20 kb ✅ 0 byte
@codesandbox/sandpack-client 10 kb 11 kb ✅ 0 byte
codesandbox-import-utils 3 kb 3 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte

@danilowoz danilowoz merged commit a3216e8 into main Feb 18, 2022
@danilowoz danilowoz deleted the feat/log-level branch February 18, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants