fix(OpenInCodeSandboxButton): preserve ?file= param for big sandboxes #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the current file stays selected even if the URL is too long and we switch to a form.
danilowoz
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a58184d:
|
|
Thanks a lot, @sophiebits, just did a few tweaks (prettier & eslint), but it looks good to me! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
Ensure that the current file stays selected even if the URL is too long and we switch to a form.
What is the current behavior?
The
file=param is set only if paramsValues.length < 1500.What is the new behavior?
It's consistently set, so the right file is opened in the new sandbox.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
[I wrote this in the GitHub web editor. Hoping to test the sandbox on this PR.]
Checklist