fix(codemirror): shift approach to remove placeholder #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shifts the approach used to replace the
placeholder
codebase to the CodeMirror editor. The previous implementation was using a React state which, for a moment, the editor didn't have any codebase at all. From now on, I brought back the previous implementation, which uses DOM API to remove the placeholder in the right moment of the CodeMirror is created, which is way faster than a React DOM flow.