Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): read-only mode #300

Merged
merged 15 commits into from
Jan 14, 2022
Merged

feat(files): read-only mode #300

merged 15 commits into from
Jan 14, 2022

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented Jan 13, 2022

This introduces a read-only mode by file or for the entire project.

Closes #296
Closes #97

@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 13, 2022 15:11 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing January 13, 2022 15:11 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 13, 2022 15:11 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing January 13, 2022 15:22 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 13, 2022 15:22 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 13, 2022 15:22 Inactive
@danilowoz danilowoz changed the title Feat/read only feat(files): read-only mode Jan 13, 2022
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 13, 2022 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing January 13, 2022 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 13, 2022 16:22 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5abeafd:

Sandbox Source
Sandpack Blog Example 1 Configuration

Copy link
Contributor

@codebryo codebryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Great job on the PR. It's very focused and well structured.
I left a few suggestions you could apply. Otherwise all good from my side.

sandpack-react/src/components/FileTabs/index.tsx Outdated Show resolved Hide resolved
sandpack-react/src/components/FileTabs/index.tsx Outdated Show resolved Hide resolved
sandpack-react/src/components/FileTabs/index.tsx Outdated Show resolved Hide resolved
sandpack-react/src/presets/Sandpack.tsx Outdated Show resolved Hide resolved
website/docs/docs/getting-started/custom-content.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 14, 2022 09:51 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 14, 2022 09:53 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 14, 2022 09:56 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing January 14, 2022 09:56 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 14, 2022 09:59 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 14, 2022 10:18 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing January 14, 2022 10:18 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 14, 2022 10:18 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing January 14, 2022 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 14, 2022 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 14, 2022 14:32 Inactive
@danilowoz danilowoz marked this pull request as ready for review January 14, 2022 14:32
@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 14, 2022 14:34 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-docs January 14, 2022 14:37 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing January 14, 2022 14:37 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme January 14, 2022 14:40 Inactive
@danilowoz danilowoz merged commit 9d5d1bf into main Jan 14, 2022
@danilowoz danilowoz deleted the feat/read-only branch January 14, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support read-only mode for CodeEditor Support read-only mode by file
2 participants