Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entry/files): prevent mismatch with pathname #268

Merged
merged 5 commits into from
Dec 28, 2021
Merged

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented Dec 20, 2021

Changes

  • Unify react-ts and react template format, in order to avoid mistakes on the pathname;
  • Introduce a function to avoid filename conflicts or having duplicates file name in the FileTabs;

Screenshot 2021-12-20 at 11 23 51

  • Improve documentation about entry point;

Closes #250

Checklist

  • Documentation
  • Tests
  • Ready to be merged

@danilowoz danilowoz requested a review from alexnm December 20, 2021 11:51
@danilowoz danilowoz self-assigned this Dec 20, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db9a68e:

Sandbox Source
Sandpack Blog Example 1 Configuration
Sandpack-Codesandbox-Rendering-Conflict (forked) Issue #250

@vercel vercel bot temporarily deployed to Preview – sandpack-docs December 20, 2021 11:53 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme December 20, 2021 11:53 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing December 20, 2021 11:53 Inactive
@danilowoz danilowoz changed the title fix(react): avoid common files mistakes fix(entry/files): prevent mismatch with pathname Dec 21, 2021
@vercel vercel bot temporarily deployed to Preview – sandpack-docs December 21, 2021 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing December 21, 2021 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-theme December 21, 2021 09:35 Inactive
@danilowoz danilowoz merged commit b618daf into main Dec 28, 2021
@danilowoz danilowoz deleted the fix/entry-point branch December 28, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: sandpack-react: Duplicate entry points
2 participants