feat(landing): add examples section #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olarclara
reviewed
Nov 23, 2021
| overflow: "hidden", | ||
| }} | ||
| > | ||
| <Text |
There was a problem hiding this comment.
There's a component SectionTitle with these exact styles.
olarclara
reviewed
Nov 23, 2021
| width: "100%", | ||
| }} | ||
| > | ||
| <SandpackExampleProvider> | ||
| <Box |
There was a problem hiding this comment.
Maybe we could use the section wrapper that is shared between the other components. It handles the layout so it's always centered on bigger screens. The content is misaligned on bigger breakpoints, below is a screenshot from my screen (3440x1440):
The Section is a wrapper that takes the whole viewport and aligns everything to the center, then there's a SectionContainer where the content will live that takes up to 2560px of the screen.
olarclara
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.