Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(landing): ui feedbacks #149

Merged
merged 4 commits into from
Nov 16, 2021
Merged

fix(landing): ui feedbacks #149

merged 4 commits into from
Nov 16, 2021

Conversation

olarclara
Copy link
Contributor

What kind of change does this pull request introduce?

Closes CSB-1782.

What is the new behavior?

  • Hover states for resources links;
  • Feedback when copying to clipboard;
  • Miscellaneous spacing adjustments;

Checklist

  • Documentation
  • Ready to be merged

@olarclara olarclara requested a review from danilowoz November 16, 2021 13:40
@olarclara olarclara self-assigned this Nov 16, 2021
@linear
Copy link

linear bot commented Nov 16, 2021

CSB-1782 UI feedbacks

  • Add hover state and maybe change the icon to confirm that the text is on the clipboard.

Screenshot 2021-11-11 at 09.50.28.png

  • @marco Vincit Is there a hover state for these links?

Screenshot 2021-11-11 at 09.52.29.png

  • Can we use a syntax highlight for this component? Maybe the Sandpack itself can handle it

Screenshot 2021-11-11 at 09.53.12.png

  • On mobile devices, this component doesn't fit to the entire screen

Screenshot 2021-11-11 at 09.54.09.png

  • Can we distribute better these columns? There is more space between them, than around the blocks.

Screenshot 2021-11-11 at 09.56.38.png

  • Add some padding around these titles, in order to avoid it "touches" the screen boundaries

Screenshot 2021-11-11 at 09.58.00.png

@olarclara olarclara requested a review from alexnm November 16, 2021 13:59
@danilowoz danilowoz merged commit 49bfe6f into main Nov 16, 2021
@danilowoz danilowoz deleted the olarclara/fix/ui-feedbacks branch November 16, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants