Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): add vanilla typescript #130

Merged

Conversation

andreifloricel
Copy link
Contributor

Resolves #127

What is the new behavior?

Provides a sandpack template with out-of-the-box support for typescript.
Technically it is similar with the existing "vanilla" sandpack template, but with .ts files instead of .js.
The resulted sandbox follows the "Vanilla Typescript" codesandbox template.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Extended Storybook

Checklist

  • Documentation "N/A"
  • Ready to be merged

@vercel
Copy link

vercel bot commented Nov 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/codesandbox/sandpack/9eAoh91cs992SzFADNHVUQR5EVcj
✅ Preview: https://sandpack-git-fork-andreifloricel-feat-vanil-a4fd7c-codesandbox1.vercel.app

@vercel vercel bot temporarily deployed to Preview November 10, 2021 13:13 Inactive
@andreifloricel
Copy link
Contributor Author

Hi @danilowoz @alexnm when is possible can you please look over this (relatively) small PR?
Sorry if I seem nagging, but I'm currently experimenting with several sandpack integrations and it would help me a lot if I had this template in a version
Thanks a lot :)

Copy link
Member

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danilowoz danilowoz merged commit d33eeb9 into codesandbox:main Nov 15, 2021
@vercel vercel bot temporarily deployed to Preview November 15, 2021 11:18 Inactive
@andreifloricel
Copy link
Contributor Author

Thanks! :)

@danilowoz danilowoz mentioned this pull request Nov 25, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add vanilla typescript template
2 participants