-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): add react typescript #114
feat(template): add react typescript #114
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/codesandbox/sandpack/A6JLuGnaYv7YAeE7HnDc1XDGdXU5 [Deployment for e3d612f failed] |
This really is awesome! I'll review and leave my thoughts as soon as I can. @alexnm who is the best person to review the |
Thanks! I just pushed a small update to the client changes as I noticed that my previous implementation was a bit over-enginereed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Andrei! Thank you for your contribution, left a few notes, then we can soon merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice addition! Happy to see React-TS in here 😄 .
Thank you! Glad I can contribute something, after using codesandbox so many times :) |
Hmm, as I created #127 and checked the existing codesandbox & sandpack templates I realised that all sandpack templates (except react) follow the sandbox structure in the sense that source files are placed under the Maybe I should adjust the |
I don't know if we have any constraints here, but I would follow the template that is used by codesandbox.io for now |
…esandbox template
Agreed, I adjusted it. |
What kind of change does this pull request introduce?
Resolves #108
What is the new behavior?
Provide a predefined template for react with out-of-the-box support for typescript
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Extended Storybook
Checklist
The public API of 'sandpack-client' has changed (added new param for 'devDependencies'). Not sure how the release process works but the
ts-ignore
fromsandpackUtils.ts
has to go.Also prettier added some formatting but I can only assume the previous code was incorrectly formatted.