-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting in Markers list seems off #47
Comments
yeah. seems like it. I did remember it all being sorted when i was first working on it, i guess i messed it up somewhere while working on it. I will fix this in 0.3 version |
Hello, Thank you for the good work. You'll find enclosed a patch that does a few fix:
With the above fix, I can only find 3 remaining problems:
|
Unfortunately I can't really accept the patch now. I am moving to a custom gui framework, with wasm (and lua) plugins scripting using wasmtime. So, there's been a lot of churn in my local repo. But fortunately, this should also solve the issue with loading/saving of package. Plugins will run in non-main threads, and won't affect the main thread which is reserved for UI + rendering + event loop. And Markers functionality will be moved to plugins. I will try my best to do an alpha release with the new changes on sunday, and then tackle the problem with marker manager. The advantage is that I can work on markers and send updates as a wasm plugin over the internet, without having to update jokolay. That should also make it faster to iterate. |
@raphaelroosz Just for my interest: Why didn't you do a pull request? |
Hi.
I imported tekkit Markers and was impressed on how nice and easy it works.
When looking at the list of Markers however, the Sorting/Order seems to be a bit mixed up.
The text was updated successfully, but these errors were encountered: