Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting in Markers list seems off #47

Open
MvBonin opened this issue Oct 8, 2023 · 4 comments
Open

Sorting in Markers list seems off #47

MvBonin opened this issue Oct 8, 2023 · 4 comments
Milestone

Comments

@MvBonin
Copy link

MvBonin commented Oct 8, 2023

Hi.
I imported tekkit Markers and was impressed on how nice and easy it works.

When looking at the list of Markers however, the Sorting/Order seems to be a bit mixed up.

image

@coderedart
Copy link
Owner

yeah. seems like it. I did remember it all being sorted when i was first working on it, i guess i messed it up somewhere while working on it.

I will fix this in 0.3 version

@coderedart coderedart added this to the Alpha 0.3 milestone Oct 8, 2023
@coderedart coderedart moved this to Todo in Jokolay Oct 8, 2023
@raphaelroosz
Copy link

various_fix_202402.txt

Hello,

Thank you for the good work.

You'll find enclosed a patch that does a few fix:

  1. order fix: BTree, HashMap, HashSet, sort or shuffle the categories in unexpected order: replaced by the OrderedHash{Map,Set} + a sort on xmls. That data structure preserve insertion order when iterating on it.
  2. log flood of a few Gb: above out of order issue may lead to key not found and a logging of key/value at each failed lookup. Now when there is a failure, a boolean is updated and once sequence is finished display existing keys (and not values) for comparison.
  3. allow boolean as text in addition to number so that "true" and "1" are both valid and mean the same (and "false" and "0").
  4. change file extension check to actual file extension, and not just the end of the file name (so that .xml and .notxml are not confused)
  5. categories without DisplayName now take the name as default substitute: this avoid to have empty rows in some packs, especially in numbers.

With the above fix, I can only find 3 remaining problems:

  1. Route tags are not implemented (check Taco default pack for "floor is lava").
  2. when a texture lookup fails, knowing which file it was required from would be nice (working on that now).
  3. the few Gb logs issue make me realize the loading/save of package is sync and make game unresponsive since it is "hidden" under the overlay which is busy logging. Other windows are responsive.

@coderedart coderedart moved this from Todo to In Progress in Jokolay Feb 23, 2024
@coderedart
Copy link
Owner

Unfortunately I can't really accept the patch now. I am moving to a custom gui framework, with wasm (and lua) plugins scripting using wasmtime. So, there's been a lot of churn in my local repo.

But fortunately, this should also solve the issue with loading/saving of package. Plugins will run in non-main threads, and won't affect the main thread which is reserved for UI + rendering + event loop. And Markers functionality will be moved to plugins.

I will try my best to do an alpha release with the new changes on sunday, and then tackle the problem with marker manager. The advantage is that I can work on markers and send updates as a wasm plugin over the internet, without having to update jokolay. That should also make it faster to iterate.

@MvBonin
Copy link
Author

MvBonin commented Feb 29, 2024

@raphaelroosz Just for my interest: Why didn't you do a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants