KUBESAW-43: Introduce LastUpdatedTime as prefered one #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 77.98% 78.06% +0.07%
==========================================
Files 47 47
Lines 1958 1965 +7
==========================================
+ Hits 1527 1534 +7
Misses 373 373
Partials 58 58
|
This was referenced May 6, 2024
Merged
Comment on lines
+51
to
+54
| if condition.LastUpdatedTime != nil { | ||
| return *condition.LastUpdatedTime | ||
| } | ||
| return condition.LastProbeTime |
There was a problem hiding this comment.
Could you please add/update the unit tests so it verifies that it give the LastUpdatedTime preference and if not set then it takes the LastProbeTime?
I mean, let's verify that it works when either from these two fields are not set. If I'm not mistaken, the current unit tests sets both fields
Signed-off-by: Feny Mehta <[email protected]>
|
MatousJobanek
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making the
LastProbeTimeoptional, introduceLastUpdatedTimeas the preferred oneThis is the next step after codeready-toolchain/api#420
This is related to