KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition

[fbm3307]

This is to replace the special ToolchainClusterCondition with the standard toolchain Condition

This is Related to Change in

• API - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition api#416
• Toolchain-Common - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition toolchain-common#391
• Host-Operator - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition host-operator#1017
• Toolchain-E2E - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition toolchain-e2e#955
• KSCTL - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition kubesaw/ksctl#38

Only change is updating the dependency of API and toolchain-common

• Registration-Service - KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition registration-service#424
• Sandbox-SRE - https://github.com/codeready-toolchain/sandbox-sre/pull/1706

[mfrancisc]

Looks good 👍

[rsoaresd]

Hello @fbm3307 👋

All the runs of this PR failed with:

expected:
        ----
        [{Ready True 0001-01-01 00:00:00 +0000 UTC AllComponentsReady  <nil>}]----
        actual:
        ----
        [{Ready False 2024-04-25 11:49:56 +0000 UTC ComponentsNotReady components not ready: [hostConnection] 2024-04-25 11:49:56 +0000 UTC}]----
        -expected
        +actual
          []v1alpha1.Condition{
        - 	{Type: "Ready", Status: "True", Reason: "AllComponentsReady"},
        + 	{
        + 		Type:               "Ready",
        + 		Status:             "False",
        + 		LastTransitionTime: s"2024-04-25 11:49:56 +0000 UTC",
        + 		Reason:             "ComponentsNotReady",
        + 		Message:            "components not ready: [hostConnection]",
        + 		LastUpdatedTime:    s"2024-04-25 11:49:56 +0000 UTC",
        + 	},
          }
        
        
    toolchain_status_assertions.go:18: 
        	Error Trace:	/tmp/toolchain-e2e/testsupport/toolchain_status_assertions.go:18
        	            				/tmp/toolchain-e2e/test/e2e/parallel/e2e_test.go:40
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestE2EFlow/verify_cluster_statuses_are_valid/verify_member_cluster_status
        	Messages:   	failed while waiting for MemberStatus
        	
(...)


host.go:1821: failed to find Space
        
    space.go:112: 
        	Error Trace:	/tmp/toolchain-e2e/testsupport/space/space.go:112
        	            				/tmp/toolchain-e2e/test/e2e/parallel/space_test.go:143
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestSpaceRoles

Very likely is the reason why PR 1017 of host-operator is failing.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (6522980) to head (644dc00).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files          29       29           
  Lines        2636     2636           
=======================================
  Hits         2216     2216           
  Misses        277      277           
  Partials      143      143           

[fbm3307]

/test e2e

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud