Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jupyter): switch from pip3 to pipx for Jupyter install #294

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Sep 20, 2024

Fixes #295

I have tested both of them on a Ubuntu noble image with pipx.

Copy link
Contributor

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnstcn I definitely trust your judgment more on the non-TypeScript files, but if you think they look good, I think this is clear to approve

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matifali matifali merged commit e11b19d into main Sep 23, 2024
2 checks passed
@matifali matifali deleted the maa/jupyter-with-pipx branch September 23, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter module not working with Ubuntu noble based images
3 participants