feat: integrate the tray app with RPC #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modularizes the tray window to use multiple Pages for the three different states: signed out, disconnected from RPC, normal - Adds the two new aforementioned pages - Adds a CredentialManager service for storing credentials in Windows Credential Manager - Adds a RpcController service for managing the connection to the backend service and reporting state changes to the ViewModel - Switches to using separate ViewModels in the Views - Switches to using Dependency Injection for instantiating Views, ViewModels and Services - Integrates the tray window into the new RpcController on Start/Stop interactions. Workspace agent updates will be handled in a separate PR
spikecurtis
reviewed
Feb 6, 2025
| services.AddSingleton<ICredentialManager, CredentialManager>(); | ||
| services.AddSingleton<IRpcController, RpcController>(); | ||
|
|
||
| services.AddTransient<TrayWindowDisconnectedViewModel>(); |
There was a problem hiding this comment.
Don't we want the view models to be singletons as well?
There was a problem hiding this comment.
I don't think we need to. They use other singletons as a source of truth for their data so there isn't really a point to making an interface for them.
Writing an interface for a ViewModel is also a pain AFAIK because of all of the observable property stuff that would need to be added to the interface for each property.
spikecurtis
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5 (I will do agent updates immediately after this)