Browser treats symlinks as files

[giantcow]

• code-server version: 1.1119-vsc1.33.1-linux-x64
• OS Version: Ubuntu 18.04.2 LTS

Description

Folder browser treats symlinks as files.

Steps to Reproduce

1. Create symlink:

   # kayo @ <snip> in /var/www/<snip> [5:28:51] 
   $ ll
   total 244K
   -rw-r--r-- 1 root root 232K Jun  1 05:25 access.log
   drwxr-xr-x 2 kayo kayo 4.0K Jun  1 04:53 coder
   -rw-r--r-- 1 root root    0 Jun  1 04:53 error.log
   drwxrwxr-x 2 kayo kayo 4.0K Jun  1 05:26 test
   
   # kayo @ <snip> in /var/www/<snip> [5:28:52] 
   $ ln -s /home/kayo/workspace/ ./
   
   # kayo @ <snip> in /var/www/<snip> [5:29:01] 
   $ ll
   total 244K
   -rw-r--r-- 1 root root 232K Jun  1 05:25 access.log
   drwxr-xr-x 2 kayo kayo 4.0K Jun  1 04:53 coder
   -rw-r--r-- 1 root root    0 Jun  1 04:53 error.log
   drwxrwxr-x 2 kayo kayo 4.0K Jun  1 05:26 test
   lrwxrwxrwx 1 kayo kayo   21 Jun  1 05:29 workspace -> /home/kayo/workspace/

2. In browser File -> Open Folder:

[sr229]

This is the File Watcher though, not the browser.

[giantcow]

The UI element that allows users to chose another working directory * :)

[sr229]

This has been fixed upstream since February 2018. I might need more info regarding this, it might be the file watcher not treating the symlink properly

CC @coadler