Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save shortcut triggers even when save dialog is open #536

Closed
Timmmm opened this issue Apr 18, 2019 · 3 comments · Fixed by #857
Closed

Save shortcut triggers even when save dialog is open #536

Timmmm opened this issue Apr 18, 2019 · 3 comments · Fixed by #857
Labels
bug Something isn't working

Comments

@Timmmm
Copy link

Timmmm commented Apr 18, 2019

  • code-server version: 1.868-vsc1.33.1
  • OS Version: Ubuntu 18.04

Description

When you press ctrl-S to save, it opens a dialog and puts a dark black rect in front of the rest of the UI. When you press ctrl-S again, it does it again! If you hold ctrl-S down it does it many times.

Steps to Reproduce

  1. Open a file.
  2. Hold ctrl-S.

You might need to use this workaround for the shortcut to work.
@Timmmm Timmmm added the bug Something isn't working label Apr 18, 2019
@nol166
Copy link
Contributor

nol166 commented Apr 18, 2019

Hey @Timmmm, thanks for the report! can you send a screenshot when you get a chance?

@Timmmm
Copy link
Author

Timmmm commented Apr 18, 2019

A screenshot doesn't really show much. Here is a video:

code-server-save-bug.mov.zip

@nol166
Copy link
Contributor

nol166 commented Apr 18, 2019

@Timmmm thanks!

@nol166 nol166 mentioned this issue Apr 18, 2019
Closed
@code-asher code-asher mentioned this issue Jul 18, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@Timmmm @nol166